Home › projects › Proparse Project › Issues

PUBTest unit test fails with current API

Tue, 2011-06-28 20:10 — KevinC
Project:Proparse Project
Component:Code
Category:bug report
Priority:minor
Assigned:Unassigned
Status:fixed
Description

The attached patch makes the following changes:

Updated to work with current API
Also separated into smaller test cases


AttachmentSize
PUBTest.patch3.8 KB

Comments

Comment viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
Wed, 2011-06-29 06:10 — john
john's picture

#1

Status:patch (code needs review)» fixed

Thanks Kevin, that's fantastic. You know, Proparse has been open source for years now, and I think you are the first person to ever submit a patch. I sure appreciate your effort, and I've applied your patch and committed the change to SVN.

On my Windows 7 machine, the test still fails because setLastModified() is not working. I don't think there's anything wrong with your patch. I think there's something in Proparse which is leaving files open. Several months ago, Carl Verbiest posted to the Proparse mailing list a description of a file locking problem.