rule "tablename" should skip buffer-compare

Project:Prolint Issue Tracker
Component:Rules
Category:bug report
Priority:normal
Assigned:jurjen
Status:closed
Description

Tim Townsend wrote:

There's code in tablename.p that excludes unqualified field name references that appear in an EXCEPT clause in a BUFFER-COPY statement. I think it should also exclude a similar clause in a BUFFER-COMPARE statement.

The relevant code looks looks like this:

   /* verify if this EXCEPT node is in a BUFFER-COPY statement */
    IF parserNodeStateHead(theNode, child) <> "BUFFERCOPY":U THEN
      RETURN.

I changed it like this and it does what I want:

   /* verify if this EXCEPT node is in a BUFFER-COPY/COMPARE statement */
    IF parserNodeStateHead(theNode, child) <> "BUFFERCOPY":U and 
       parserNodeStateHead(theNode, child) <> "BUFFERCOMPARE":U THEN
      RETURN.

Comments

Comment viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
jurjen's picture

#1

Status:active» fixed

Thanks Tim, you are right.
I have checked it in into Subversion as revision 330.


#2

Status:fixed» closed