Home › forums › Prolint

false positive by rule "tablename"?

Tue, 2008-04-29 10:49 — marcel_h

The tablename rule excludes the fields in the except/using option of the buffer-compare statement. Is there a valid reason this rule has to fire for fields in the except/using phrase of buffer-compare statements or is this a false positive?

The following statement gives a rule violation on the custnum and name field.

BUFFER-COMPARE sports.customer EXCEPT custnum name TO tCust SAVE RESULT IN lCompare.


‹ how to sync editor in OpenEdge Architect?? nopprsininclude rule ›

Comment viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
Tue, 2008-04-29 11:45 — jurjen
jurjen's picture

re: False positive by rule "tablename"

I guess it is a false positive.

When you look in the sourcecode prolint/rules/tablename.p at internal procedure "ExcluseUsing", you see that BUFFER-COPY and BUFFER-COMPARE are both handled as exceptions.
But when you look at internal procedure "ExcludeExcept" you see that only BUFFER-COPY is handled. That is inconsistent, I think BUFFERCOMPARE should be added.


Tue, 2008-04-29 21:10 — jurjen
jurjen's picture

re: False positive by rule "tablename"

I have fixed this and checked it in into subversion:
http://websvn.oehive.org/filedetails.php?repname=prolint&path=%2Ftrunk%2...


Tue, 2008-05-06 16:12 — marcel_h

re: False positive by rule "tablename"

Jurjen, thanks! it does the job now correctly.