The OpenEdge Hive - issues for Prolint Issue Tracker

table usage

atuldalvi123 — Mon, 16 May 2016 08:03:29 +0000

Ho do we create a rule which will identify whether the program is using a DB table or not ?

ABL(4GL) General Programming Group

Prolint - tablename rule for class method parameters not working

atuldalvi123 — Thu, 12 May 2016 19:06:38 +0000

I am having a class with method and that method is having 2 input parameters assigning to some other local vars.

Using Prolint I am generating ouput for the same class and output is showing warning like "inpt1 must be qualified with table name" and same for the 2nd input parameter for the line number where I am assigning it to other local vars.

But the same is working for procedure file having input parameters, no warning in the output page.

Please suggest

ABHack Group

Prolint 73 - Progress v9.1e - tty - installation issues

bmack — Tue, 21 May 2013 21:25:38 +0000

I need to find a source code analyzer for my company's Progress code and Prolint sounds like a perfect option. We use Progress v9.1e on a Linux server and the CHUI procedure editor for development here. My attempts to install Prolint have been unsuccessful. I downloaded Prolint v73 and its directories are included in the PROPATH. But there were run-time errors when trying to run prolint/launch/start.p (see attached pdf). I could not find very much related to running this from the CHUI Progress editor. Does anyone have any advice?

Prolint

Use of dbaliases.d - prolint 74

Duze — Wed, 25 Apr 2012 14:25:51 +0000

We have some programs that use aliases that consists of 1 character (don't know why but they exsist).
for example in the code they use s..

I can find in the Prolint documentation that we can use the file /settings/dbaliases.d to prevent compile errors warnings for those in Prolint.
I've create that file and inserted the following lines
"s" "mydatabase"
"m" "mydatabase"

But when I run the program that uses these aliases in Prolint I still get
compile failed
Unknown database name s. (855)

Is there anyone that uses this dbaliases.d file?

Prolint

Detect unused USING

tamhas — Wed, 07 Mar 2012 19:31:25 +0000

Notice any USING statement which is not utilized in resolving references in the class.

Codeparse group

function or non-void method should return a value

jurjen — Wed, 13 Apr 2011 09:01:37 +0000

OpenEdge allows to write a method that does not contain a "return" statement, even when it is not a void method. We'd like a warning (from Prolint) for that

Prolint

new rule: cleanup-code can be moved into a finally block

jurjen — Tue, 22 Mar 2011 10:25:19 +0000

When a function, method or internal procedure has statements close to the end like 'delete object', 'delete procedure', 'set-size(mem)=0', then Prolint may suggest that you put a "finally:... end" block around it.

Prolint

adecomm.pl not available in OEArchitect

jurjen — Wed, 07 Feb 2007 18:09:05 +0000

The setup instruction for Prolint says you need to extract adecomm.pl (see instruction) but this pl file is apparently not shipped with the OpenEdge Architect edition of 10.1A.

reported by Glen West.

Prolint

prolint says "ERROR: compile failed" for a new compiler warning

jurjen — Thu, 25 Nov 2010 12:33:42 +0000

A sourcefile contains the following statement:

define variable hBuffer as handle no-undo initial ?.

The progress compiler gives the following warning:

"Invalid INITIAL option ignored for HANDLE or OBJECT REFERENCE variable (3349)"

Prolint recognizes this as a compile error. Instead it should send it to the outputhandler as a warning and assume that the source compiles fine.

Prolint

ABBREVKWD: false positive on field names assigned using :: shortcut

Stefan Drissen — Tue, 09 Feb 2010 10:03:55 +0000

Issue

When using the :: shortcut for hb:BUFFER-FIELD("language":U):BUFFER-VALUE, hb::language the ABBREVKWD rule complains that language is an abbreviated keyword for LANGUAGES.

Test case

DEFINE TEMP-TABLE tt NO-UNDO
FIELD language AS CHARACTER.

DEFINE VARIABLE hb AS HANDLE NO-UNDO.

hb = TEMP-TABLE tt:DEFAULT-BUFFER-HANDLE.
hb:BUFFER-CREATE().
hb::language = "nl":U.

Prolint

NOUNDO: false positive on dataset-handles

Stefan Drissen — Tue, 09 Feb 2010 09:51:38 +0000

Fix:

Add to inspectnode prolint/rules/noundo.p:

WHEN "DATASETHANDLE":U THEN IF vartype='parameter':U THEN
/* suppress warning on "DEFINE .. parameter dataset-handle ..." */
ASSIGN havevar = FALSE.

Prolint

Check if propsuper is running

Niek — Mon, 23 Mar 2009 11:32:40 +0000

Logwin8.w => save log as => tabfile.p gives an error about dynamic function ProlintProperty.
This is because Prolint does: RUN DecrementProlintPropertySubscribers. which tells propsuper to shutdown (if no-one is actively listening)

tabfile.p (responsible for the call) or Logwin8.w (responsible for the button)
should check if propsuper is running with a construction like in core/prolint.p

Prolint

Varusage.SkipNewShared not implemented correctly

Niek — Thu, 02 Apr 2009 12:51:28 +0000

In the query using the SkipNewShared it is used in the wrong way, resulting in wrong results when SkipNewShared is no.
The code:
tt_object.newshared <> SkipNewShared
should be changed to:
(not tt_object.newshared or not SkipNewShared)

Prolint

rule tablename false positives when forward function decl. <> function decl

Niek — Mon, 23 Mar 2009 10:39:45 +0000

This was resolved on issue 1403, but the find "prototype" should be find FIRST "prototype" on line 394.

Prolint

namecheck

Niek — Sat, 07 Mar 2009 16:48:10 +0000

Don't know if anyone uses the default namecheck.p, but there is an error in the code.
CASE btt_Object.ObjType
should be CASE btt_Object.ParamType
So INPUT, OUTPUT and INPUT-OUTPUT paramters will have to have i, o and io as prefix.

Prolint

core/Prolint.p gives error on get-row()

Niek — Tue, 03 Mar 2009 07:40:14 +0000

When compilation "fails" with for example error 468, the compiler:error-status is set, error-status:num-messages is set, error-status:get-number(1) works but compiler:get-row(1) gives an error 4065 as if the call to the method is wrong?!?

Solution: Prolint.p should also skip compiler:error-number 468 (where it skips 4345 and 6430)

P.S. Logged a bug with Progress.

Prolint

file 'checkin-event.p' calls function 'fnRtbGetLintFile' with wrong parameter

edzerdboersma — Thu, 29 Jan 2009 18:58:42 +0000

In file 'checkin-event.p' are some calls to the function 'fnRtbGetLintFile' in file 'rt_customfunc.p'.
The calls are made with a wrong parameter: The parameter is a "recid" but has to be a "rowid".
I have included a corrected checkin-event.p, see the attachment.

Prolint

Prolint Result messages?

Duze — Fri, 10 Oct 2008 09:47:44 +0000

When I run 'Lint Files' I get a few stange messages:
- Expected proparse version 3.1b, found 3.1c02
I've downloaded the latest ProParse and Prolint, why do I get this message??? Can't I use the latest ProLint with the latest ProParse??

- Multiple Lines with '8:50: unexpected token: no-undo'
Whats the reason for this message in Prolint??

Prolint Version 72
ProParse 3.1c02
Progress OpenEdge 10.1A230

Prolint

request rule: SUPER should be last call in a 'teardown' method

jurjen — Tue, 22 Jul 2008 10:00:17 +0000

Consider this example code:

   METHOD PUBLIC OVERRIDE VOID CreateThis ():
     SUPER:CreateThis().
     /* add some custom stuff to 'this' */
   END METHOD.

   METHOD PUBLIC OVERRIDE VOID DeleteThis ():
     SUPER:DeleteThis(). 
     /* remove the custom stuff from 'this' */
   END METHOD.

As you can see, SUPER:DeleteThis() is now the first statement in the DeleteThis method but I believe it makes more sense, generally, when it is the last statement.
I have no idea how to automate such a code review though.

Prolint

locate private methods that are never called

jurjen — Wed, 09 Jul 2008 15:05:57 +0000

Make a new Prolint rule that warns when a class appears to have a private method that is never called.

Prolint